Set the device name from the CEC_OSD_NAME environment variable#62
Open
christos-kakris wants to merge 3 commits intotrainman419:masterfrom
Open
Set the device name from the CEC_OSD_NAME environment variable#62christos-kakris wants to merge 3 commits intotrainman419:masterfrom
christos-kakris wants to merge 3 commits intotrainman419:masterfrom
Conversation
|
For your consideration, I slightly simplified this commit. I made it silently truncate long names, replaced the snprintf() with a strncpy() and use the system defined LIBCEC_OSD_NAME_SIZE to restrict the length of the name. The change is here: master...retsyx:python-cec:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not a C++ programmer so I struggled with the correct way to achieve what I needed. So I've gone with the approach of an environment variable to set the device name in the initialisation code. I hope this is okay.